fix: visibility_filter returns wrong type for indexing#1316
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
visibility_filteringaussian_renderer/__init__.pyuses(radii > 0).nonzero(), which returns a 2D index tensor of shape(N, 1)instead of a boolean mask.This 2D index tensor causes incorrect advanced indexing behavior when used downstream in
train.pyfor operations like:and in
add_densification_stats:These callsites expect a 1D boolean mask for proper element selection, but the 2D index tensor from
.nonzero()triggers PyTorch advanced indexing, which can produce unexpected shapes and incorrect results.Fix
Removed the
.nonzero()call sovisibility_filterreturnsradii > 0directly -- a proper 1D boolean mask that works correctly with all downstream indexing operations.